Thread:
 bad testing logic 
 jeitemgie   07 Jun 2008, 11:13 

Comment
Prev. thread 
 Next thread
 
Prev. posting 
 Next posting
From: jeitemgie (07 Jun 2008, 11:13) Replies: 0, Views: 587
Subject: bad testing logic
if (propertyNames.length != previousState.length
            && previousState.length != currentState.length)

(1 != 2) && (2 != 3) -> true  ok
(1 != 1) && (1 != 2) -> false !!! WRONG should be true
(1 != 2) && (2 != 2) -> false !!! WRONG should be true
(1 != 1) && (1 != 1) -> false ok


should be

if (propertyNames.length != previousState.length
            || previousState.length != currentState.length)

(1 != 2) || (2 != 3) -> true  ok
(1 != 1) || (1 != 2) -> true ok
(1 != 2) || (2 != 2) -> true ok
(1 != 1) || (1 != 1) -> false ok
Prev. thread 
 Next thread
 
Prev. posting 
 Next posting
© Copyright 2006, Red Hat Middleware, LLC. All rights reserved. JBoss and Hibernate are registered trademarks and servicemarks of Red Hat, Inc. [Privacy Policy]